Fix specify version within extra node module#437
Open
hinrichd wants to merge 3 commits intoSchwarzIT:mainfrom
Open
Fix specify version within extra node module#437hinrichd wants to merge 3 commits intoSchwarzIT:mainfrom
hinrichd wants to merge 3 commits intoSchwarzIT:mainfrom
Conversation
hinrichd
force-pushed
the
fix-specify-version-within-extra-node-module
branch
2 times, most recently
from
290187e to
810eed2
Compare
Contributor
Author
|
@dirien Something went wrong. I have started a new pr! Pleace have a look. |
Collaborator
|
Hey @hinrichd, thanks for picking this up again! Looks like this branch has merge conflicts with main. Could you rebase it so we can get CI to run and move forward with the review? Let us know if you run into any trouble with the rebase. |
Signed-off-by: Hinrich <16142189+hinrichd@users.noreply.github.com>
Signed-off-by: Hinrich <16142189+hinrichd@users.noreply.github.com>
Signed-off-by: Hinrich <16142189+hinrichd@users.noreply.github.com>
hinrichd
force-pushed
the
fix-specify-version-within-extra-node-module
branch
from
810eed2 to
6bb0249
Compare
Contributor
Author
|
Hey @dirien, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for making
node-red ⚙betterRetry!!!
This is a small fix up on issue --> #318
So I do not open an new issue.
Split and rsplit will not work properly in some conditions, even the array index -1 will be empty in some common situations. There for i have changed the behaviour of splitting the module name and version for the following common cases and avoid multi /,@ matches:
NODE-RED-NODE-MYSQL
NODE-RED-NODE-MYSQL@2.0.0
NODE-RED-NODE-MYSQL/
@FLOWFUSE/NODE-RED-DASHBOARD
@FLOWFUSE/NODE-RED-DASHBOARD/
@FLOWFUSE/NODE-RED-DASHBOARD@1.2.3
Regards
Also verify you have: